[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 8 Aug 2007 11:14:19 +0200
From: Andi Kleen <ak@...e.de>
To: Glauber de Oliveira Costa <gcosta@...hat.com>
Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
rusty@...tcorp.com.au, mingo@...e.hu, chrisw@...s-sol.org,
jeremy@...p.org, avi@...ranet.com, anthony@...emonkey.ws,
virtualization@...ts.linux-foundation.org, lguest@...abs.org,
Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 3/25] [PATCH] irq_flags / halt routines
> +#ifdef CONFIG_PARAVIRT
> +#include <asm/paravirt.h>
> +# ifdef CONFIG_X86_VSMP
> +static inline int raw_irqs_disabled_flags(unsigned long flags)
> +{
> + return !(flags & X86_EFLAGS_IF) || (flags & X86_EFLAGS_AC);
> +}
> +# else
> +static inline int raw_irqs_disabled_flags(unsigned long flags)
> +{
> + return !(flags & X86_EFLAGS_IF);
> +}
> +# endif
You should really turn the vsmp special case into a paravirt client first
instead of complicating all this even more.
> +#ifndef CONFIG_PARAVIRT
> +#define raw_safe_halt native_raw_safe_halt
> +#define halt native_halt
> +#endif /* ! CONFIG_PARAVIRT */
This seems inconsistent
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists