[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 8 Aug 2007 11:25:37 +0200
From: Andi Kleen <ak@...e.de>
To: Glauber de Oliveira Costa <gcosta@...hat.com>
Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
rusty@...tcorp.com.au, mingo@...e.hu, chrisw@...s-sol.org,
jeremy@...p.org, avi@...ranet.com, anthony@...emonkey.ws,
virtualization@...ts.linux-foundation.org, lguest@...abs.org,
Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 13/25] [PATCH] turn msr.h functions into native versions
On Wednesday 08 August 2007 06:19, Glauber de Oliveira Costa wrote:
> +static __always_inline long long vget_cycles_sync(void)
Why is there a copy of this function now? That seems wrong
> + native_read_tscp(&p);
The instruction is called rdtscp not read_tscp. Please follow that
> +#define rdtsc(low, high) \
This macro can be probably eliminated, no callers in kernel
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists