[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 8 Aug 2007 12:26:55 +0200
From: Andi Kleen <ak@...e.de>
To: Nick Piggin <npiggin@...e.de>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Ingo Molnar <mingo@...e.hu>, linux-arch@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [patch 2/2] x86_64: ticket lock spinlock
> *
> * (the type definitions are in asm/spinlock_types.h)
> */
>
> +#if (NR_CPUS > 256)
> +#error spinlock supports a maximum of 256 CPUs
> +#endif
> +
> static inline int __raw_spin_is_locked(raw_spinlock_t *lock)
> {
> - return *(volatile signed int *)(&(lock)->slock) <= 0;
> + int tmp = *(volatile signed int *)(&(lock)->slock);
Why is slock not volatile signed int in the first place?
> - int oldval;
> + short tmp;
> + short oldval;
Broken white space?
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists