linux-kernel - Re: Question: RT schedular : task_tick_rt(struct rq *rq, struct task_struct *p) : decreases overhead when rq->nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070809082656.GA21973@elte.hu>
Date:	Thu, 9 Aug 2007 10:26:56 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Dmitry Adamushko <dmitry.adamushko@...il.com>
Cc:	Mitchell Erblich <erblichs@...thlink.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Question: RT schedular : task_tick_rt(struct rq *rq, struct
	task_struct *p) : decreases overhead when rq->nr_running == 1


* Dmitry Adamushko <dmitry.adamushko@...il.com> wrote:

> I guess, the following thing would do a better job:
> 
> - we do need reschedule() _only_ if there are other task on the _same_ 
> queue (for this prio level) :

ah, indeed.

> --- kernel/sched_rt-prev.c      2007-08-09 09:55:10.000000000 +0200
> +++ kernel/sched_rt.c   2007-08-09 09:58:53.000000000 +0200
> @@ -207,6 +207,11 @@ static void task_tick_rt(struct rq *rq,
>                 return;
> 
>         p->time_slice = static_prio_timeslice(p->static_prio);
> +
> +       /* We are the only element on the queue. */
> +       if (p->run_list.prev == p->run_list.next)
> +               return;
> +

i've applied your patch - could you please send a SOB line?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/