linux-kernel - Re: Question: sched_rt.c : is RT check needed within a RT func? dequeue_task_rt() calls update_curr_rt() which checks for priority of RR or FIFO :

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b647ffbd0708090147p2b30e6c8g82aeb8880520265b@mail.gmail.com>
Date:	Thu, 9 Aug 2007 10:47:11 +0200
From:	"Dmitry Adamushko" <dmitry.adamushko@...il.com>
To:	"Mitchell Erblich" <erblichs@...thlink.net>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: Question: sched_rt.c : is RT check needed within a RT func? dequeue_task_rt() calls update_curr_rt() which checks for priority of RR or FIFO :

On 09/08/07, Mitchell Erblich <erblichs@...thlink.net> wrote:
> 1) * Possible wasted stats overhead during dequeue..
> sched_rt.c:
> Is RT check needed within a RT func?
> dequeue_task_rt() calls update_curr_rt()
> which checks for priority of RR or FIFO.
> [ ... ]
> Thus, I think those two lines could be removed.
>
> 2) nit....
> The comment within sched_rt.c
> ----->   Adding/removing a task to/from a priority array:
> Is placed before dequeue_task_rt() where
> enqueue_task_rt() is placed above the comment
>

Both suggestions sound good. I guess, a patch would be welcomed  :-)


>
> Mitchell Erblich
>

-- 
Best regards,
Dmitry Adamushko
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/