linux-kernel - Re: [PATCH 4/5 -v2] Added generic lg.h in the include/linux directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0708090817360.29847@gandalf.stny.rr.com>
Date:	Thu, 9 Aug 2007 08:19:11 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
cc:	Rusty Russell <rusty@...tcorp.com.au>, lguest <lguest@...abs.org>,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	virtualization <virtualization@...ts.linux-foundation.org>,
	Glauber de Oliveira Costa <glommer@...il.com>,
	Jes Sorensen <jes@....com>, Carsten Otte <cotte@...ibm.com>,
	Andi Kleen <ak@...e.de>
Subject: Re: [PATCH 4/5 -v2] Added generic lg.h in the include/linux directory

--
On Thu, 9 Aug 2007, Stephen Rothwell wrote:

> Hi Steven,
>
> I am just being pedantic here (and I should have beaten up on Rusty
> before now ...  :-)
>
> On Thu, 09 Aug 2007 00:36:30 -0400 Steven Rostedt <rostedt@...dmis.org>
> wrote:
> >
> > --- a/include/asm-i386/lg.h
> > +++ b/include/asm-i386/lg.h
> > @@ -1,5 +1,5 @@
> > -#ifndef _LGUEST_H
> > -#define _LGUEST_H
> > +#ifndef _I386_LGUEST_H
> > +#define _I386_LGUEST_H
>
> Maybe _ASM_LG_H or _I386_LG_H ? And there is a comment on the #endif at
> the end of the file that should match.
>
> > +++ b/include/linux/lg.h
> > @@ -0,0 +1,30 @@
> > +#ifndef _LINUX_LGUEST_H
> > +#define _LINUX_LGUEST_H
>
> Maybe _LINUX_LG_H ?
>
> Also (this is for Rusty) include/linux/lguest.h is protected by
> _ASM_LGUEST_H ...

Hah! in my lguest64 tree, I fixed all these. But I forgot to do the
changes when making the patches for upstream.  I'll make note and fix them
in my next patch series (unless Rusty can pull my stuff in now and then I
can apply on top of them ;-)

Thanks,

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/