linux-kernel - Re: [PATCH] Add missing KERN_<level> to multiline printk(KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070809123241.GA12818@linux-mips.org>
Date:	Thu, 9 Aug 2007 13:32:41 +0100
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, Greg KH <gregkh@...e.de>,
	Jeff Garzik <jeff@...zik.org>,
	Russell King <rmk@....linux.org.uk>,
	Lennert Buytenhek <kernel@...tstofly.org>,
	Bryan Wu <bryan.wu@...log.com>, "H.PeterAnvin" <hpa@...or.com>,
	Greg Ungerer <gerg@...inux.org>,
	Kumar Gala <galak@...nel.crashing.org>,
	Grant Grundler <grundler@...isc-linux.org>,
	Christoph Lameter <clameter@....com>
Subject: Re: [PATCH] Add missing KERN_<level> to multiline
	printk(KERN_<level>...)

On Wed, Aug 08, 2007 at 05:28:46PM -0700, Joe Perches wrote:

> Some uses of printk are missing KERN_<level> on the second
> and subsequent lines.
> 
> For instance:
> 
> printk(KERN_INFO "line1: %d\nline2: %d\n", val1, val2);
> 
> Line1 is marked log_level: info
> Line2 is marked log_level: unknown
> 
> Some lines have trailing spaces after \n, removed where appropriate.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

For the MIPS bits.

Acked-by: Ralf Baechle <ralf@...ux-mips.org>

But not without the note that mentioned printk should be deleted because
this is not Windows 95.

  Ralf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/