linux-kernel - Re: 2.6.23-rc2-mm1 -- PPC G5 kernel compile failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Aug 2007 14:04:49 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Krzysztof Helt <krzysztof.h1@...pl>
Cc:	linux-kernel@...r.kernel.org, drfickle@...ibm.com, mel@....ul.ie,
	Andy Whitcroft <apw@...dowen.org>
Subject: Re: 2.6.23-rc2-mm1 -- PPC G5 kernel compile failure

Seeing the following compile error on a G5 mac:

  drivers/video/tdfxfb.c: In function 'tdfxfb_setup':
  drivers/video/tdfxfb.c:1341: error: 'opt' undeclared (first use in this
                                                                 function)
  drivers/video/tdfxfb.c:1341: error: (Each undeclared identifier is
                                                        reported only once
  drivers/video/tdfxfb.c:1341: error: for each function it appears in.)

This seems to be the following fragment from tdfxfb-hardware-cursor:

+               } else if (!strcmp(this_opt, "hwcursor")) {
+                       hwcursor = simple_strtoul(opt + 9, NULL, 0);

I guess the nieve fix would be s/opt/this_opt, but I am also
suspicious of the +9 here as hwcursor is only 8 long?  Now this
seems to take a numeric value and I assume that is via hwcursor=N,
if so then the +9 would make sense _if_ the strcmp was against
"hwcursor=".

Krzysztof?

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/