[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070810074140.GB28264@elte.hu>
Date: Fri, 10 Aug 2007 09:41:40 +0200
From: Ingo Molnar <mingo@...e.hu>
To: David Woodhouse <dwmw2@...radead.org>
Cc: torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [MTD] Fix CFI build error with meaningless
nonfunctional .config
* David Woodhouse <dwmw2@...radead.org> wrote:
> On Mon, 2007-08-06 at 18:15 +0200, Ingo Molnar wrote:
> > randconfig testing on .23-rc2 triggered the following build error:
>
> When building NOR flash support, you have compile-time options for the
> bus width and the number of individual chips which are interleaved
> together onto that bus. The code to deal with arbitrary geometry is a
> bit convoluted, and people want to just configure it for the specific
> hardware they have, to avoid the runtime overhead.
>
> Selecting _none_ of the available options doesn't make any sense. You
> should have at least one. This makes it build though, since people
> persist in trying.
i didnt persist - randconfig picked it - it's a legit .config.
> +#ifndef cfi_interleave
> +#warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work.
> +static inline int cfi_interleave(void *cfi)
> +{
> + BUG();
> + return 0;
looks quite quirky. Is there no Kconfig-space solution for this?
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists