linux-kernel - Re: + sysctl-error-on-bad-sysctl-tables.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1k5s3zquo.fsf@ebiederm.dsl.xmission.com>
Date:	Fri, 10 Aug 2007 03:22:23 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Alexey Dobriyan <adobriyan@...ru>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: + sysctl-error-on-bad-sysctl-tables.patch added to -mm tree

Alexey Dobriyan <adobriyan@...ru> writes:

> It gives false positive on kernel.pty.nr:
>
> 	sysctl table check failed: /kernel/pty/nr .1.62.2 No data
>
> However, ->data is set in unix98_pty_init().

It's a race.  

Data isn't set until after we enable the sysctl subsystem.

In practice I doubt it matters but I think would rather fix
that one case (by using register_sysctl_table) then not have
the check.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/