linux-kernel - Re: + sysctl-remove-binary-sysctl-support-where-it-clearly-doesnt-work.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1fy2rzqn7.fsf@ebiederm.dsl.xmission.com>
Date:	Fri, 10 Aug 2007 03:26:52 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Alexey Dobriyan <adobriyan@...ru>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: + sysctl-remove-binary-sysctl-support-where-it-clearly-doesnt-work.patch added to -mm tree

Alexey Dobriyan <adobriyan@...ru> writes:

>> @@ -1124,7 +1118,6 @@ static struct ctl_table fs_table[] = {
>>  		.proc_handler	= &proc_dointvec,
>>  	},
>>  	{
>> -		.ctl_name	= FS_NRFILE,
>>  		.procname	= "file-nr",
>>  		.data		= &files_stat,
>>  		.maxlen		= 3*sizeof(int),
>
> Why? It will work just fine through default sysctl(2) writeback.

Well write doesn't happen.  But even more so proc_nr_files() dynamically
generates files_stat.nr_files.  That doesn't happen on the generic
sysctl path, and thus it's broken.

Yes.  I'm being picky, because at some point in the past before
that was a per cpu variable the code worked, and won't look broken
now unless you examine the contents of the data.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/