linux-kernel - Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070810143342.173d2637@the-village.bc.nu>
Date:	Fri, 10 Aug 2007 14:33:42 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	ebiederm@...ssion.com (Eric W. Biederman)
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Alexey Dobriyan <adobriyan@...ru>,
	axboe@...nel.dk
Subject: Re: [PATCH 08/10] sysctl: Remove broken cdrom binary sysctls

On Thu, 09 Aug 2007 19:01:14 -0600
ebiederm@...ssion.com (Eric W. Biederman) wrote:

> 
> The binary interface for the cdrom sysctls can't possilby work.
> So remove the binary sysctls and update the test for finding
> out which sysctl table entry we are dealy with to use the procname
> and not the ctl_name (which I am removing).

NAK

I've no problem with the basic idea of removing the names from user
space, but you've just demonstrated with the patch below that it causes
some quite revolting changes for the bad in code which previously was
nicely done switch statements and is now a nest of string compares and
inline code.

There are very good reasons to have a cookie in the sysctl entry for
internal use and which is private to the subsystem using the sysctl (ie
not for sysctl() use and not neccessarily unique).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/