linux-kernel - Re: [3/3] 2.6.23-rc2: known regressions v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200708112342.01989.rjw@sisk.pl>
Date:	Sat, 11 Aug 2007 23:42:01 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Meelis Roos <mroos@...ux.ee>
Cc:	Michal Piotrowski <michal.k.k.piotrowski@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-pm@...ts.linux-foundation.org, Pavel Machek <pavel@....cz>
Subject: Re: [3/3] 2.6.23-rc2: known regressions v2

On Saturday, 11 August 2007 12:53, Meelis Roos wrote:
> > > > 3. Can you please check if this patch changes anything:
> > > > http://marc.info/?l=linux-mm-commits&m=118669680811669&w=2
> > > 
> > > Tried it on current git, kernel/power/Kconfig gave 2 rejects.
> > > Tried on 2.6.23-rc2, still 2 rejects from the same file, .rej below:
> > 
> > Sorry, but:
> > 
> > rafael@...ercik:~/src/linux-2.6> git-pull git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> > Already up-to-date.
> > rafael@...ercik:~/src/linux-2.6> cat ~/pm-fix-dependencies-of-config_suspend-and-config_hibernation-updated-3x.patch | patch -p1
> > patching file arch/x86_64/defconfig
> > patching file include/linux/cpu.h
> > patching file kernel/cpu.c
> > patching file kernel/power/Kconfig
> > 
> > How come?
> 
> Hmm, must have been mangled on the web (downloaded via wget so should be 
> byte-by-byte exact). I now downloaded it from akpm-s broken-out tarball 
> and this one applied fine.
> 
> The patch changes the warning to a different warning, it's now
> kernel/power/Kconfig:79:warning: 'select' used by config symbol 'PM_SLEEP_SMP' refers to undefined symbol 'HOTPLUG_CPU'
> 
> The warning also appears when running just "make ARCH=ppc" after
> "make ARCH=ppc oldconfig".

Yes, I have reproduced it now.

Well, it's clearly a false positive, since none of the options PM_SLEEP_SMP
depends on is set in your .config.  Also, it seems to be ppc-specific (for
example, if I change the architecture to powerpc, the warning doesn't show up).

The only problem I see here is that the warning in fact should not be printed,
but I don't know how to make the build system stop printing it.

Greetings,
Rafael


-- 
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/