linux-kernel - [PATCH -mm] drivers/scsi/megaraid.c: bugfix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200708111025.12885.m.kozlowski@tuxland.pl>
Date:	Sat, 11 Aug 2007 10:25:12 +0200
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	James Bottomley <James.Bottomley@...eleye.com>
Cc:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	Joe Perches <joe@...ches.com>
Subject: [PATCH -mm] drivers/scsi/megaraid.c: bugfix

Hello,

	This is one of the 'possible downsides: embarrassment' situation described
by Randy in his papers on linux development. I introduced a bug while doin conversion
to kzalloc and this is a fix. We can not return here as we are under lock. Live and learn.

Please apply.

Regards,

	Mariusz

Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

 drivers/scsi/megaraid.c | 116094 -> 116063 (-31 bytes)
 drivers/scsi/megaraid.o | 257984 -> 257868 (-116 bytes)

 drivers/scsi/megaraid.c |    3 ---
 1 file changed, 3 deletions(-)

--- linux-2.6.23-rc2-mm2-a/drivers/scsi/megaraid.c	2007-08-10 12:46:10.000000000 +0200
+++ linux-2.6.23-rc2-mm2-b/drivers/scsi/megaraid.c	2007-08-11 10:03:25.000000000 +0200
@@ -4409,9 +4409,6 @@ mega_internal_command(adapter_t *adapter
 	memset(scmd, 0, sizeof(Scsi_Cmnd));

 	sdev = kzalloc(sizeof(struct scsi_device), GFP_KERNEL);
-	if (!sdev)
-		return -ENOMEM;
-
 	scmd->device = sdev;

 	scmd->device->host = adapter->host;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/