linux-kernel - Re: [PATCH] Fix triplefault on x86-64 bootup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0708121051140.30176@woody.linux-foundation.org>
Date:	Sun, 12 Aug 2007 10:56:21 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Andi Kleen <ak@...e.de>
cc:	Petr Vandrovec <petr@...drovec.name>, discuss@...-64.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix triplefault on x86-64 bootup

On Sun, 12 Aug 2007, Andi Kleen wrote:
> 
> Can you please just apply the patch series please? 
> This one is fixed in  "Make patching more robust, fix paravirt issue"

I *had* applied the patch series, Andi. And that one will do

	memcpy(addr, opcode, len);

even though "addr" itself may be all of memcpy().

So the code was buggy, and Petr fixed it, and your patch-series didn't fix 
*anything*. In fact, from what I can tell, it's the one that introduced 
the problem, because before thatone hit, we'd always do the two-byte 
sequence on its own (since the "nop_out()" on the rest of the memcpy would 
be called later, and separately, once it didn't matter any more).

So out of 12 patches, 2 caused machines to not even boot. Not good.

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/