linux-kernel - Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <139264.28979.qm@web36601.mail.mud.yahoo.com>
Date:	Sun, 12 Aug 2007 12:50:44 -0700 (PDT)
From:	Casey Schaufler <casey@...aufler-ca.com>
To:	Jan Engelhardt <jengelh@...putergmbh.de>,
	Casey Schaufler <casey@...aufler-ca.com>
Cc:	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, akpm@...l.org, torvalds@...l.org
Subject: Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel


--- Jan Engelhardt <jengelh@...putergmbh.de> wrote:


> >> >+static int smack_task_movememory(struct task_struct *p)
> >> >+{
> >> >+	int rc;
> >> >+
> >> >+	rc = smk_curacc(smk_of_task(p), MAY_WRITE);
> >> >+	return rc;
> >> >+}
> >> 
> >> Uh...
> >> 
> >> {
> >> 	return smk_curacc(smk_of_task(p), MAY_WRITE);
> >> }
> >> 
> >> (also others)
> >
> >That was a little excessive, wasn't it?
> 
> How do you mean? I was just suggesting to collapse the three [four] lines
> into
> one, getting rid of the tempotemporaries in a lot of these functions,
> for example,

Sorry, I meant that my code was excessive, not your comment.
Your comment was fine and most welcome. I'm sorry that I was
unclear and sounded defensive.


Casey Schaufler
casey@...aufler-ca.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/