linux-kernel - Re: [PATCH 4/4] signalfd: make it group-wide, fix posix-timers scheduling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070813191407.GA816@tv-sign.ru>
Date:	Mon, 13 Aug 2007 23:14:07 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Davide Libenzi <davidel@...ilserver.org>,
	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Michael Kerrisk <mtk-manpages@....net>,
	Roland McGrath <roland@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH 4/4] signalfd: make it group-wide, fix posix-timers scheduling

On 08/12, Oleg Nesterov wrote:
>
> Untested, user visible change.
> 
> With this patch any thread can dequeue its own private signals via signalfd,
> even if it was created by another sub-thread.
> 
> To do so, we pass "current" to dequeue_signal() if the caller is from the same
> thread group. This also fixes the scheduling of posix timers broken by the
> previous patch.
> 
> If the caller doesn't belong to this thread group, we can't handle __SI_TIMER
> case properly anyway. Perhaps we should forbid the cross-process signalfd usage
> and convert ctx->tsk to ctx->sighand.

Sorry, the patch is not complete. I forgot about signalfd_poll() and somehow I
forgot to actually tweak de_thread(). I'll send a new one tomorrow.

Something should be done for 2.6.23, imho.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/