linux-kernel - Re: Linux 2.6.22.2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070813233932.GA8852@kroah.com>
Date:	Mon, 13 Aug 2007 16:39:32 -0700
From:	Greg KH <greg@...ah.com>
To:	Ayaz Abdulla <aabdulla@...dia.com>
Cc:	Prakash Punnoor <prakash@...noor.de>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org, stable@...nel.org
Subject: Re: Linux 2.6.22.2

On Thu, Aug 09, 2007 at 05:40:16PM -0400, Ayaz Abdulla wrote:
>  Yes, you are right. Copy and paste error. I have attached a patch which will 
>  fix this issue.
> 
>  Thanks for catching it.
>  Ayaz
> 
>  Signed-off-by: Ayaz Abdulla <aabdulla@...dia.com>
> 
> 
>  Prakash Punnoor wrote:
> > Hi,
> > I just noticed that PHY_OUI_VITESSE == PHY_OUI_REALTEK. Is that really 
> > intentional?
> >> diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
> >> index 42ba1c0..a361dba 100644
> >> --- a/drivers/net/forcedeth.c
> >> +++ b/drivers/net/forcedeth.c
> >> @@ -550,6 +550,8 @@ union ring_type {
> >> /* PHY defines */
> >> #define PHY_OUI_MARVELL	0x5043
> >> #define PHY_OUI_CICADA	0x03f1
> >> +#define PHY_OUI_VITESSE	0x01c1
> >> +#define PHY_OUI_REALTEK	0x01c1
> > - (?=                 =?)
> > //\ Prakash Punnoor /\\
> > V_/                 \_V

> --- old/drivers/net/forcedeth.c	2007-08-09 17:37:12.000000000 -0400
> +++ new/drivers/net/forcedeth.c	2007-08-09 17:37:07.000000000 -0400
> @@ -551,7 +551,7 @@
>  #define PHY_OUI_MARVELL	0x5043
>  #define PHY_OUI_CICADA	0x03f1
>  #define PHY_OUI_VITESSE	0x01c1
> -#define PHY_OUI_REALTEK	0x01c1
> +#define PHY_OUI_REALTEK	0x0732
>  #define PHYID1_OUI_MASK	0x03ff
>  #define PHYID1_OUI_SHFT	6
>  #define PHYID2_OUI_MASK	0xfc00

Is this something that really matters for this driver?  And if so, care
to send this patch to mainline as well as to the stable@...nel.org team
with a proper changelog?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/