linux-kernel - Re: [dm-devel] [patch 01/11] dm-snap: Replace special round

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 13 Aug 2007 11:35:03 +0200
From:	Jan Blunck <jblunck@...e.de>
To:	agk@...hat.com
Cc:	dm-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [dm-devel] [patch 01/11] dm-snap: Replace special round_down()

On Fri, Aug 10, Jan Blunck wrote:

> This patch removes the special round_down() to next power of 2 implementation
> used only at one place in the snapshot target. It is replaced by an equivalent
> 1 << fls() which might use an architecture specific implementation.

Err, ok this is the second fix for this patch. I hope it is the last. It
doesn't make any sense to have hash_size be defined as sector_t. Same goes for
max_buckets.

Regards,
	Jan

-- 
Jan Blunck <jblunck@...e.de>

View attachment "dm-snap-remove-round_down.diff" of type "text/x-patch" (1302 bytes)