linux-kernel - Re: 2.6.23-rc2-mm2: strtol_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Aug 2007 21:12:58 +0530 (IST)
From:	Satyam Sharma <satyam@...radead.org>
To:	Alexey Dobriyan <adobriyan@...ru>
cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: 2.6.23-rc2-mm2: strtol_check_range patches

On Mon, 13 Aug 2007, Alexey Dobriyan wrote:

> Andrew please drop
> 	introduce-strtol_check_range-fix.patch
> 	introduce-strtol_check_range.patch
> from -mm.
> 
> strtol_check_range() semantics is broken, because caller can't distinguish
> -E from valid negative number if he wants to negative integers.

As you wrote, the comment does mention that you can't use this to convert
negative integers, and it WARN()'s if the user tries that anyway.

> Comment
> mentions this, but we don't want to such horrible and not well thought
> out function to lib/ .
> 
> If anything it should be strtonum() with additional trailing '\n' check.

That's fine, I'll use strtonum() in any case. It turns out the behaviour
that we want is precisely what strtonum() offers, plus that also works for
negative integers, so we might as well just copy it over.

Andrew, I'll diff a new patch implementing strtonum(3) _not_ based on this
one, so you may safely drop this.

Thanks,
Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/