linux-kernel - Re: [2.6 patch] cpqphp_ctrl.c: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070813090533.4a363c5a.kristen.c.accardi@intel.com>
Date:	Mon, 13 Aug 2007 09:05:33 -0700
From:	Kristen Carlson Accardi <kristen.c.accardi@...el.com>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	linux-pci@...ey.karlin.mff.cuni.cz,
	pcihpd-discuss@...ts.sourceforge.net, akpm@...ux-foundation.org
Subject: Re: [2.6 patch] cpqphp_ctrl.c: remove dead code

On Fri, 10 Aug 2007 01:39:10 +0200
Adrian Bunk <bunk@...nel.org> wrote:

> As I've wrote in the patch description, all it does is to remove an if() 
> check that could never be false (which is easily verifyable if you look 
> at the source code).
> 
> I've also verified that my patch does not change a single bit in the 
> object file (after compilation with gcc 4.2.1).

while you are correct that your patch will not change the object,
the reason I think that we should not do this patch is because it appears
to me that this code path was meant to be taken, and perhaps it was a 
mistake to return -ENOMEM further up (the reason the code isn't taken).
It seems to me that the thing to do is to leave the code as is, and then when
someone picks up the code again, they can clean it up after they've determined
they truly don't want that code path taken.

My definition of trivial is a patch that is both simple and obviously the 
right thing to do.
Kristen

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/