[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <200708142058.38314.rjw@sisk.pl>
Date: Tue, 14 Aug 2007 20:58:37 +0200
From: "Rafael J. Wysocki" <rjw@...k.pl>
To: Andres Salomon <dilinger@...ued.net>
Cc: Pavel Machek <pavel@....cz>, akpm@...ux-foundation.org,
kernel list <linux-kernel@...r.kernel.org>
Subject: Re: + serial-turn-serial-console-suspend-a-boot-rather-than-compile-time-option.patch added to -mm tree
On Tuesday, 14 August 2007 20:44, Andres Salomon wrote:
> On Tue, 14 Aug 2007 20:23:23 +0200
> "Rafael J. Wysocki" <rjw@...k.pl> wrote:
>
> > On Tuesday, 14 August 2007 12:39, Pavel Machek wrote:
> > > Hi!
> > >
> > > > Thanks, updated below!
> > > >
> > > >
> > > >
> > > > serial: turn serial console suspend a boot rather than compile time option
> > > >
> > > > From: Andres Salomon <dilinger@...ian.org>
> > > >
> > > > Currently, there's a CONFIG_DISABLE_CONSOLE_SUSPEND that allows one to stop
> > > > the serial console from being suspended when the rest of the machine goes
> > > > to sleep. This is incredibly useful for debugging power
> > > > management-related
> > >
> > > Actually, this should not be configurable. We should simply enable
> > > console during suspend for consoles that can handle this,
> > > automatically.... this patch does just that. I hope I separated it
> > > correctly.
>
>
> I disagree. I expect that this will break things; I would prefer to keep
> it as a configuration option. If you want to enable it by default, that's
> one thing; but give users the option to turn it off.
Hm, I think this can be combined with your patch:
(1) add a command line parameter that will turn the suspending of consoles on
(2) add a switch that will disable the thing regardless of (1) if netconsole is
enabled (like in the Pavel's patch).
Greetings,
Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists