linux-kernel - Re: [patch] slab: revert "slab: fix alien cache handling"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0708141200470.29373@schroedinger.engr.sgi.com>
Date:	Tue, 14 Aug 2007 12:02:52 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	"Siddha, Suresh B" <suresh.b.siddha@...el.com>
cc:	lethal@...ux-sh.org, penberg@...helsinki.fi,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [patch] slab: revert "slab: fix alien cache handling"

On Mon, 13 Aug 2007, Siddha, Suresh B wrote:

> > Only if you find another way to fix the bug that is addressed there.
> 
> Does the appended version fix both the issues? Name alien in cache_free_alien
> is confusing, as the function does two things. free through alien caches
> or direct remote free..

Yes calling cache_free_alien is not necessary if you just have a single 
node. All memory is node local in that case.

I do not think that cache_free_alien is confusing since the name refers to 
the function freeing an alien object. That alien object can be freed to an 
alien cache or directly to a remote slab.

Acked-by: Christoph Lameter <clameter@....com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/