linux-kernel - Re: [PATCH 1/4] Add ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46C212E2.3020401@intel.com>
Date:	Tue, 14 Aug 2007 13:38:58 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Rick Jones <rick.jones2@...com>
CC:	David Miller <davem@...emloft.net>, greearb@...delatech.com,
	jeff@...zik.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

Rick Jones wrote:
> David Miller wrote:
>> From: Ben Greear <greearb@...delatech.com>
>> Date: Fri, 10 Aug 2007 15:40:02 -0700
>>
>>
>>> For GSO on output, is there a generic fallback for any driver that
>>> does not specifically implement GSO?
>>
>> Absolutely, in fact that's mainly what it's there for.
>>
>> I don't think there is any issue.  The knob is there via
>> ethtool for people who really want to disable it.
> 
> Just to be paranoid (who me?) we are then at a point where what happened 
> a couple months ago with forwarding between 10G and IPoIB won't happen 
> again - where things failed because a 10G NIC had LRO enabled by default?

we still have the NETIF_F_LRO flag which Jeff will keep around. Perhaps the 
IPoIB code can force this to _off_ when setting it up? (or at least warn about it).

Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/