lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Aug 2007 21:47:16 -0700 (PDT) From: Scott Thompson <postfailathushmaildotcom@...oo.com> To: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, postfail@...hmail.com Subject: [PATCH 3/3] /drivers/net ucc_geth ioremap balancing/returncode check (resend) resending patchset against 2.6.23-rc3 for /drivers/net ioremap balancing / return check, previous patchset contained wordwrap errors: corrects: --sbus_ioremap return unchecked. --ioremap function unchecked --function failure cases did not clean up ioremap'd values. lne390.c -- believe had incorrect/not ideal variable check on if for iounmap this audit was only for files directly in drivers/net directory, not the full tree. Signed-off-by: Scott Thompson <postfail <at> hushmail.com> ---------------------------------------------------------- diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index 12e01b2..30acbe2 100644 --- a/drivers/net/ucc_geth.c +++ b/drivers/net/ucc_geth.c @@ -2430,6 +2430,11 @@ static int ucc_struct_init(struct ucc_geth_private *ugeth) ugeth->ug_regs = (struct ucc_geth *) ioremap(uf_info->regs, sizeof(struct ucc_geth)); + if (!ugeth->ug_regs){ + ugeth_err("%s: Failed to ioremap.", __FUNCTION__); + return -ENOMEM; + } + return 0; } ____________________________________________________________________________________ Choose the right car based on your needs. Check out Yahoo! Autos new Car Finder tool. http://autos.yahoo.com/carfinder/ ____________________________________________________________________________________ Need a vacation? Get great deals to amazing places on Yahoo! Travel. http://travel.yahoo.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists