lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Aug 2007 00:30:03 +0900 From: Tejun Heo <htejun@...il.com> To: Cornelia Huck <cornelia.huck@...ibm.com> CC: Alan Stern <stern@...land.harvard.edu>, Florin Iucha <florin@...ha.net>, USB development list <linux-usb-devel@...ts.sourceforge.net>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Greg KH <gregkh@...e.de>, Michal Piotrowski <michal.k.k.piotrowski@...il.com>, "Randy. Dunlap" <rdunlap@...otime.net> Subject: Re: [linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351 Cornelia Huck wrote: > On Wed, 15 Aug 2007 23:54:43 +0900, > Tejun Heo <htejun@...il.com> wrote: > >> Alan Stern wrote: >>> I think we can simply remove the error message. There's no obvious >>> reason why sysfs_remove_bin_file() should complain about attempts to >>> remove a nonexistent file; sysfs_remove_file() doesn't. >>> >>> This patch will get rid of the annoying error messages. It won't do >>> anything about your keyboard's tendency to spontaneously stop working, >>> alas. >> Agreed but I think sysfs_remove_bin_file() should relay the return value >> from sysfs_has_and_remove() to the caller. > > Three comments: > > - Randy made sysfs_remove_bin_file() return void in commit > 995982ca79d9262869513948ec7c540f32035491. > > - For symmetry reasons, sysfs_remove_file() should then also pass the > return value on. > > - I'm not sure who wants to care whether they removed an existing or > non-existing file. But maybe I'm just unimaginative. Hmmm... Well, failure information is lost there, so I was a bit worried. It probably doesn't really matter and can be easily changed later if needed. If sysfs_remove_file() returns void, I have no objection. Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists