[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070815084454.09B061BF982@siro.lan>
Date: Wed, 15 Aug 2007 17:44:53 +0900 (JST)
From: yamamoto@...inux.co.jp (YAMAMOTO Takashi)
To: svaidy@...ux.vnet.ibm.com
Cc: a.p.zijlstra@...llo.nl, dhaval@...ux.vnet.ibm.com,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
ebiederm@...ssion.com, containers@...ts.osdl.org,
akpm@...ux-foundation.org, xemul@...nvz.org, menage@...gle.com,
balbir@...ux.vnet.ibm.com
Subject: Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)
> YAMAMOTO Takashi wrote:
> >> + lock_meta_page(page);
> >> + /*
> >> + * Check if somebody else beat us to allocating the meta_page
> >> + */
> >> + race_mp = page_get_meta_page(page);
> >> + if (race_mp) {
> >> + kfree(mp);
> >> + mp = race_mp;
> >> + atomic_inc(&mp->ref_cnt);
> >> + res_counter_uncharge(&mem->res, 1);
> >> + goto done;
> >> + }
> >
> > i think you need css_put here.
>
> Thats correct. We do need css_put in this path.
>
> Thanks,
> Vaidy
v5 still seems to have the problem.
YAMAMOTO Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists