linux-kernel - Re: [PATCH 002 of 5] Replace bio_data with blk_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18115.63917.990694.904646@notabene.brown>
Date:	Thu, 16 Aug 2007 17:15:57 +1000
From:	Neil Brown <neilb@...e.de>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	linux-kernel@...r.kernel.org, Tejun Heo <htejun@...il.com>
Subject: Re: [PATCH 002 of 5] Replace bio_data with blk_rq_data

On Thursday August 16, jens.axboe@...cle.com wrote:
> On Thu, Aug 16 2007, NeilBrown wrote:
> > 
> > Almost every call to bio_data is for the first bio
> > in a request.  A future patch will add some accounting
> > information to 'struct request' which will need to be
> > used to find the start of the request in the bio.
> > So replace bio_data with blk_rq_data which takes a 'struct request *'
> > 
> > The one exception is in dm-emc were using
> >    page_address(bio->bi_io_vec[0].bv_page);
> > is appropriate.
> 
> This (and 3+4) just look like preparatory patches if we want to merge
> the full patchset, not bug fixes. I seem to recall you had more bug
> fixes or cleanups in your patchset, maybe I was mistaken. So nak for now
> for 2-4, I'd apply 5 but it depends on the previous.
> 

I don't remember other bug fixes, but I'll look through and check.

2 and 3 are very simple changes that - I think - make it clearer what
is happening.

And I felt 5 was a sufficient improvement to justify it and 4...

I'll go hunting and see what other preliminaries I can find.

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/