linux-kernel - [PATCH] NFS: fix /proc/sys oops after module removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200708160300.AA00236@paprika.lab.ntt.co.jp>
Date:	Thu, 16 Aug 2007 12:00:42 +0900
From:	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
To:	trond.myklebust@....uio.no
Cc:	nfs@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	moriai.satoshi@....ntt.co.jp
Subject: [PATCH] NFS: fix /proc/sys oops after module removal

NFS client made without CONFIG_NFS_V4 option does not call
nfs_unregister_sysctl() when the module is unloaded, and
causes kernel oopses.  For instance, the oopses will occur
when accessing /proc/sys.

This fixes the problem.

Note that register_nfs_fs() requires no change in this regard.
It looks similar at the first glance, but written properly.

Signed-off-by: Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
---
 fs/nfs/super.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index b2a851c..e784310 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -345,8 +345,8 @@ void __exit unregister_nfs_fs(void)
 	unregister_shrinker(&acl_shrinker);
 #ifdef CONFIG_NFS_V4
 	unregister_filesystem(&nfs4_fs_type);
-	nfs_unregister_sysctl();
 #endif
+	nfs_unregister_sysctl();
 	unregister_filesystem(&nfs_fs_type);
 }
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/