linux-kernel - Re: [PATCH 1/2] Add a new field `name' to struct linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0708161128g71ca385ak6ddcb1b36d7fabc2@mail.gmail.com>
Date:	Thu, 16 Aug 2007 14:28:43 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Jie Zhang" <jie.zhang@...log.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Add a new field `name' to struct linux_binfmt

On 8/16/07, Jie Zhang <jie.zhang@...log.com> wrote:
> This patch addes a new `name' field to struct linux_binfmt and
> initialize it in each binfmt type.
>
> A second blackfin arch patch will use this field to distinguish `flat'
> binfmt with `FDPIC ELF'.
>
> Is it OK? Any comments?

the other possibility would be to not make linux_binfmt definitions
static and put appropriate prototypes in the fs.h header ... then you
could do:
if (current->binfmt == aout_format) {
  ... aout stuff ...
}

then again, this goes against the dynamic nature of the binfmt itself
... and the idea that the binfmt should not matter to anything else in
the kernel once it's executing ...
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/