linux-kernel - Re: drivers/infiniband/mlx/mad.c misplaced ;

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46C3D09B.6060405@intel.com>
Date:	Wed, 15 Aug 2007 21:20:43 -0700
From:	"Kok, Auke" <auke-jan.h.kok@...el.com>
To:	Joe Perches <joe@...ches.com>
CC:	netfilter-devel@...ts.netfilter.org, coreteam@...filter.org,
	linux-kernel@...r.kernel.org
Subject: Re: drivers/infiniband/mlx/mad.c misplaced ;

Joe Perches wrote:
> On Wed, 2007-08-15 at 19:19 -0700, Kok, Auke wrote:
>> Joe Perches wrote:
>>> On Wed, 2007-08-15 at 19:58 -0400, Dave Jones wrote:
>>> There's more than a few of these (not inspected).
>>> $ egrep -r --include=*.c "\bif[[:space:]]*\([^\)]*\)[[:space:]]*\;" * 
>>> arch/sh/boards/se/7343/io.c:    if (0) ;
>>> drivers/atm/iphase.c:     if (!desc1) ;
>>> drivers/infiniband/hw/mlx4/mad.c:       if (!err);
>>> drivers/isdn/capi/capiutil.c:   else if (c <= 0x0f);
>>> drivers/net/tokenring/ibmtr.c:  else if (ti->shared_ram_paging == 0xf);  /* No paging in adapter */
>>> drivers/s390/scsi/zfcp_erp.c:           if (status == ZFCP_ERP_SUCCEEDED) ;     /* no further action */
>>> fs/hostfs/hostfs_user.c:        if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ;
>>> net/netfilter/xt_u32.c:         if (skb->len < 4 || pos > skb->len - 4);
>>> sound/pci/au88x0/au88x0_synth.c:                                if (eax == 0) ;
>> sounds like an excellent candidate check for checkpatch.pl !!!
> 
> I think it's poor style and all of these should go away.
> 
> the netfilter one appears to be a real error too.

I was more thinking of making sure that none of these slip back in...

Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/