lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Aug 2007 13:25:40 +0400 From: Pavel Emelyanov <xemul@...nvz.org> To: Andrew Morton <akpm@...l.org> CC: Alexey Dobriyan <adobriyan@...nvz.org>, Sukadev Bhattiprolu <sukadev@...ibm.com>, Linux Containers <containers@...ts.osdl.org>, Oleg Nesterov <oleg@...sign.ru>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, devel@...nvz.org Subject: [PATCH] Fix check for return value of create_pid_namespace The function in question returns ERR_PTR-s to indicate the error, while the caller checks for return value to be NULL. Found during testing the OpenVZ kernel with pid namespaces. Signed-off-by: Pavel Emelyanov <xemul@...nvz.org> Signed-off-by: Alexey Dobriyan <adobriyan@...nvz.org> Cc: Sukadev Bhattiprolu <sukadev@...ibm.com> Cc: Oleg Nesterov <oleg@...sign.ru> --- kernel/pid.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/pid.c b/kernel/pid.c index faad017..cb1f3cb 100644 --- a/kernel/pid.c +++ b/kernel/pid.c @@ -543,7 +543,7 @@ struct pid_namespace *copy_pid_ns(unsign goto out_put; new_ns = create_pid_namespace(old_ns->level + 1); - if (new_ns != NULL) + if (!IS_ERR(new_ns)) new_ns->parent = get_pid_ns(old_ns); out_put: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists