linux-kernel - Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070818.010412.72709547.anemo@mba.ocn.ne.jp>
Date:	Sat, 18 Aug 2007 01:04:12 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	jengelh@...putergmbh.de
Cc:	david-b@...bell.net, a.zummo@...ertech.it,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
	dbrownell@...rs.sourceforge.net
Subject: Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

On Fri, 17 Aug 2007 17:37:01 +0200 (CEST), Jan Engelhardt <jengelh@...putergmbh.de> wrote:
> >Most busses don't have managed device IDs like PCI, USB, or PNP.
> >
> >The platform, spi, and i2c busses use the driver name, which is
> >obviously managed within the scope of all Linux drivers.
> >
> Yeah but that does not tell me why it needs the ds1742 alias
> if scripts (whatever they use to discover it) could modprobe rtc-ds1742
> instead.

Well, the rtc-ds1742 platform driver uses a string "ds1742" for its
platform_driver definition.

static struct platform_driver ds1742_rtc_driver = {
	.probe		= ds1742_rtc_probe,
	.remove		= __devexit_p(ds1742_rtc_remove),
	.driver		= {
		.name	= "ds1742",
		.owner	= THIS_MODULE,
	},
};

We can change the name string and all definitions of "ds1742" platform
device instead of adding MODULE_ALIAS.  It is easy since there are
only a few users in kernel.  If that was preferred, I can rewrite this
patch.

---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/