linux-kernel - Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200708170926.45194.david-b@pacbell.net>
Date:	Fri, 17 Aug 2007 09:26:44 -0700
From:	David Brownell <david-b@...bell.net>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
Cc:	jengelh@...putergmbh.de, a.zummo@...ertech.it,
	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com
Subject: Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

On Friday 17 August 2007, Atsushi Nemoto wrote:
> 
> > My preferred style for such patches puts the MODULE_ALIAS up
> > near the strange driver name, so it's more clear what's going
> > on.  Putting all the MODULE_*() stuff at the end of the file
> > gets confusing in this case.
> 
> OK, then I should update my patches anyway ;)

I wasn't going to be too picky here, but if you volunteer
to make things even better, I'll be happy!  :)


> Which do you prefer, MODULE_ALIAS or change some strings?
> 
> I guess there are some out-of-tree users of this driver, but fixing
> them is really trivial, so I don't think this is a big compatibility
> problem.

If you're willing to fix all the in-tree users, I'd think
not needing MODULE_ALIAS is best in the long term.

For these I2C drivers, the conversion to support "new style"
driver binding is new in 2.6.23, yes?  If so, I don't see any
real downside to making the driver and module names match.

_ Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/