linux-kernel - [PATCH] __group_complete_signal: eliminate unneeded wakeup of ->group_exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070817164710.GA3535@tv-sign.ru>
Date:	Fri, 17 Aug 2007 20:47:10 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Roland McGrath <roland@...hat.com>, linux-kernel@...r.kernel.org
Subject: [PATCH] __group_complete_signal: eliminate unneeded wakeup of ->group_exit_task

Cleanup. __group_complete_signal() wakes up ->group_exit_task twice. The second
wakeup's state includes TASK_UNINTERRUPTIBLE, which is not very appropriate.

Change the code to pass the "correct" argument to signal_wake_up() and kill now
unneeded wake_up_process().

Signed-off-by: Oleg Nesterov <oleg@...sign.ru>

--- t/kernel/signal.c~2_GCS_NOWAKEUP	2007-08-12 19:48:26.000000000 +0400
+++ t/kernel/signal.c	2007-08-17 20:23:59.000000000 +0400
@@ -911,8 +911,7 @@ __group_complete_signal(int sig, struct 
 			do {
 				sigaddset(&t->pending.signal, SIGKILL);
 				signal_wake_up(t, 1);
-				t = next_thread(t);
-			} while (t != p);
+			} while_each_thread(p, t);
 			return;
 		}
 
@@ -930,13 +929,11 @@ __group_complete_signal(int sig, struct 
 		rm_from_queue(SIG_KERNEL_STOP_MASK, &p->signal->shared_pending);
 		p->signal->group_stop_count = 0;
 		p->signal->group_exit_task = t;
-		t = p;
+		p = t;
 		do {
 			p->signal->group_stop_count++;
-			signal_wake_up(t, 0);
-			t = next_thread(t);
-		} while (t != p);
-		wake_up_process(p->signal->group_exit_task);
+			signal_wake_up(t, t == p);
+		} while_each_thread(p, t);
 		return;
 	}
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/