linux-kernel - Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1187316783.822.19.camel@localhost>
Date:	Thu, 16 Aug 2007 19:13:03 -0700
From:	Joe Perches <joe@...ches.com>
To:	Junio C Hamano <gitster@...ox.com>
Cc:	Rene Herman <rene.herman@...il.com>, git@...r.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Arjan van de Ven <arjan@...radead.org>,
	Trond Myklebust <trond.myklebust@....uio.no>,
	Mariusz Kozlowski <m.kozlowski@...land.pl>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch -
	scripts/get_maintainer.pl

On Tue, 2007-08-14 at 18:31 -0700, Junio C Hamano wrote:
>    On the other hand, git-send-email _is_ all about sending it
>    out, and it needs to know who your patch should reach.  I
>    think it makes sense to have one script that, given a set of
>    paths that are affected, gives a list of potentially
>    interested people (that is "Finding" part -- and I see there
>    are 600+ patches to implement this on the list), and a new
>    option to git-send-email to (1) inspect the patch to see what
>    paths are affected, and (2) call that "Find" script to figure
>    out whom to send it to, and probably asking for confirmation.

Sorry, not a git developer, so the paths are wrong.
This seems to work:

Example:

git-send-email \
   --cc-cmd "perl scripts/get_maintainers.pl -non -multiline" foo.diff

--- git-send-email.pl	2007-08-16 19:06:07.000000000 -0700
+++ /usr/local/bin/git-send-email	2007-05-01 11:59:14.000000000 -0700
@@ -47,9 +47,6 @@ Options:
    --cc           Specify an initial "Cc:" list for the entire series
                   of emails.
 
-   --cc-cmd       Specify a command to execute per file which adds
-                  per file specific cc address entries
-
    --bcc          Specify a list of email addresses that should be Bcc:
 		  on all the emails.
 
@@ -143,7 +140,7 @@ my (@to,@cc,@initial_cc,@bcclist,@xh,
 
 # Behavior modification variables
 my ($chain_reply_to, $quiet, $suppress_from, $no_signed_off_cc,
-	$dry_run, $cc_cmd) = (1, 0, 0, 0, 0, 0);
+	$dry_run) = (1, 0, 0, 0, 0);
 my $smtp_server;
 my $envelope_sender;
 
@@ -176,7 +173,6 @@ my $rc = GetOptions("from=s" => \$from,
 		    "subject=s" => \$initial_subject,
 		    "to=s" => \@to,
 		    "cc=s" => \@initial_cc,
-		    "cc-cmd=s" => \$cc_cmd,
 		    "bcc=s" => \@bcclist,
 		    "chain-reply-to!" => \$chain_reply_to,
 		    "smtp-server=s" => \$smtp_server,
@@ -611,16 +607,6 @@ foreach my $t (@files) {
 		}
 	}
 	close F;
-
-	if (${cc_cmd} ne "") {
-	    my $output = `${cc_cmd} $t`;
-	    my @lines = split("\n", $output);
-	    foreach my $c (@lines) {
-		push @cc, $c;
-		printf("(sob) Adding cc: %s from cc-cmd: '%s'\n", $c, $t) unless $quiet;
-	    }
-	}
-
 	if (defined $author_not_sender) {
 		$author_not_sender = unquote_rfc2047($author_not_sender);
 		$message = "From: $author_not_sender\n\n$message";


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/