linux-kernel - Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200708171250.09653.david-b@pacbell.net>
Date:	Fri, 17 Aug 2007 12:50:09 -0700
From:	David Brownell <david-b@...bell.net>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Atsushi Nemoto <anemo@....ocn.ne.jp>, jengelh@...putergmbh.de,
	a.zummo@...ertech.it, linux-kernel@...r.kernel.org,
	rtc-linux@...glegroups.com, Greg KH <greg@...ah.com>
Subject: Re: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware

On Friday 17 August 2007, Kay Sievers wrote:
> On Fri, 2007-08-17 at 09:55 -0700, David Brownell wrote:
> > On Friday 17 August 2007, Kay Sievers wrote:
> > > Again,
> > 
> > "Again"?
> 
> We exchanges several mails a few weeks ago after the Debian bug caused
> by a modprobe loop. 

Which has been fixed for some time now; it was caused by legacy
drivers, which are incapable of hotplugging.

> > > the only sane solution is to provide MODALIAS="platform:<name>" 
> > > from the platform bus, and adding the aliases to drivers who support
> > > autoloading. Modalias strings are not free-text strings, they are
> > > required to be prefixed by the subsystem.
> > 
> > If so, then whoever tried to change the usage of module aliases
> > in that way goofed in several ways.  First, by not changing all
> > the in-kernel uses.  Second, by not changing all the out-of-tree
> > uses in various distros, toolchains, etc.  Third, by not even
> > documenting that change...
> 
> Yes, please fix the misuse of MODALIAS.

I'm not the one who's advocating a change here.  If you want to
first change/break and then fix things, all of that is up to you.

> > > Please change that stuff, and the bugs which we 
> > > are fighting magically go away, because module-init-tools alias
> > > resolving works like it does for every other subsystem in the kernel.
> > 
> > Those bugs would be ... what?  "We" haven't observed anything
> > attributable to this usage, which has been common for years now.
> 
> Loops of modprobe by modules requesting itself, you worked around that
> in the recent kernel,

Legacy drivers of the "create my own device node" ilk will never
be able to hotplug ... since it's the /sys/device/... node creation
which causes any "find my driver" hotplug event.  (Like "i82365".)

That bug has been *FIXED* for some time now, as far as I hear.

And that's based on having looked at several hundred platform
drivers to make sure of it... mostly that's not legacy code, so
it can hotplug just fine.

> but that broke other setups.

That's news to me.  Of course, the breakage could also be in
those setups ... legacy drivers with legacy setup shouldn't
break, but they don't necessarily obey enough of the rules
that newer tools expect.

> And module-init-tools  
> "blacklist" does not work, because platform uses no alias, but a plain
> driver name. That should be fixed, please, please, please...

Module init tools "blacklist" is squirrely, yes ... it
ignores *most* of the names that "modprobe" accepts,
so it can't actually "blacklist" modules from loading.

The ancient "alias modname none" trick still has life.

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/