linux-kernel - Re: [PATCH 2/6] Use one zonelist that is filtered instead of multiple zonelists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0708171355580.9635@schroedinger.engr.sgi.com>
Date:	Fri, 17 Aug 2007 13:59:26 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Mel Gorman <mel@....ul.ie>
cc:	Lee.Schermerhorn@...com, ak@...e.de, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH 2/6] Use one zonelist that is filtered instead of multiple
 zonelists

On Fri, 17 Aug 2007, Mel Gorman wrote:

> +/* Returns the first zone at or below highest_zoneidx in a zonelist */
> +static inline struct zone **first_zones_zonelist(struct zonelist *zonelist,
> +					enum zone_type highest_zoneidx)
> +{
> +	struct zone **z;
> +	for (z = zonelist->zones; zone_idx(*z) > highest_zoneidx; z++);
> +	return z;
> +}

The formatting above is a bit confusing. Add requires empty lines and put 
the ; on a separate line.


> +/* Returns the next zone at or below highest_zoneidx in a zonelist */
> +static inline struct zone **next_zones_zonelist(struct zone **z,
> +					enum zone_type highest_zoneidx)
> +{
> +	for (++z; zone_idx(*z) > highest_zoneidx; z++);

Looks weird too.

++z on an earlier line and then

	for ( ; zone_idx(*z) ...)

?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/