linux-kernel - Re: [PATCH] - git-send-email.perl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7vy7g9enqd.fsf@gitster.siamese.dyndns.org>
Date:	Fri, 17 Aug 2007 16:38:02 -0700
From:	Junio C Hamano <gitster@...ox.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Rene Herman <rene.herman@...il.com>, git@...r.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Arjan van de Ven <arjan@...radead.org>,
	Trond Myklebust <trond.myklebust@....uio.no>,
	Mariusz Kozlowski <m.kozlowski@...land.pl>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH] - git-send-email.perl

Joe Perches <joe@...ches.com> writes:

> Here's a path to enable a command line option
> that takes a string argument
>
> 	cc-cmd
>
> This modifies the @cc array to include whatever
> output is produced by cc_cmd $patchfile
>
> cccmd can be stored in a config settings file
>
> previous versions of this patch were submitted
> against an older version of git-send-email.perl

... Signed-off-by: ...


> diff --git a/git-send-email.perl b/git-send-email.perl
> index 69559b2..828a77a 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -46,6 +46,9 @@ Options:
>     --cc           Specify an initial "Cc:" list for the entire series
>                    of emails.
>  
> +   --cc-cmd       Specify a command to execute per file which adds
> +                  per file specific cc address entries
> +
>     --bcc          Specify a list of email addresses that should be Bcc:
>  		  on all the emails.
>  

I do not see a patch to "Documentation/git-send-email.txt" here...

> @@ -652,11 +657,21 @@ foreach my $t (@files) {
>  		}
>  	}
>  	close F;
> +
> +	if (${cc_cmd} ne "") {
> +	    my $output = `${cc_cmd} $t`;
> +	    my @lines = split("\n", $output);
> +	    foreach my $c (@lines) {
> +		push @cc, $c;
> +		printf("(cc-cmd) Adding cc: %s from: '%s'\n", $c, $cc_cmd)
> +		    unless $quiet;
> +	    }
> +	}
> +

Something like this, with appropriate error checking, perhaps?

	open my $cc, "${cc_cmd} $t |";
        while (my $c = <$cc>) {
        	...
	}
        close $cc;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/