linux-kernel - Re: [draft] Blackfin Early Printk implmentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 18 Aug 2007 08:23:33 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Robin Getz <rgetz@...ckfin.uclinux.org>
Cc:	linux-kernel@...r.kernel.org, Gerd Hoffmann <kraxel@...hat.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Bryan Wu <bryan.wu@...log.com>,
	Sonic Zhang <sonic.adi@...il.com>,
	Mike Frysinger <vapier.adi@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [draft] Blackfin Early Printk implmentation

> > What was preventing you from just using the x86_64 code here?
> 
> Some was borrowed - but not much. since we don't support vga, or 16550 UARTs
> (Blackfin has it's own on-chip UART), I don't think this would work. 
> 
> Maybe I'm missing something - but I don't think so. Every one who implements
> implements direct IO to the hardware (except me, since I put it into the driver
> file, and force Sonic - the serial driver developer - to maintain it forever).
> 
> Most of the other early printks talks directly to the hardware.
I only looked at your version and it looked general thats why I brought
up the code sharing idea - which I agree is not possible.

> > Thinking that all should do the same so maybe alpha ought to change...
> 
> When I looked at all the printk implementations, I thought they were all
> kind of hokey, and not very common - but what do you want for a debug interface
> that lasts less than 5 seconds?
> 
> ./arch/x86_64/kernel/early_printk.c
> ./arch/blackfin/kernel/early_printk.c
> ./arch/sh64/kernel/early_printk.c
> ./arch/sh/kernel/early_printk.c
> ./arch/i386/kernel/early_printk.c
> ./arch/mips/kernel/early_printk.c
> 
> I didn't see an alpha implementation - where is it done?
Alpha uses the imlementation in lib/*print.c somehow.
And I think the right choice would be to implement
a private version of early_printk for alpha like the
other architectures do.

Thanks for the split-up. I could follow the changes now.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/