linux-kernel - Re: [PATCH 1/1] ensure we don't use bootconsoles after init has been released

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200708201522.47591.rgetz@blackfin.uclinux.org>
Date:	Mon, 20 Aug 2007 15:22:47 -0400
From:	Robin Getz <rgetz@...ckfin.uclinux.org>
To:	"Andrew Morton" <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org
Cc:	"Paul Mundt" <lethal@...ux-sh.org>,
	"Mike Frysinger" <vapier.adi@...il.com>,
	linux-kernel@...r.kernel.org, "Gerd Hoffmann" <kraxel@...hat.com>
Subject: Re: [PATCH 1/1] ensure we don't use bootconsoles after init has been released

Try #4... (sorry)
 
From: Robin Getz <rgetz@...ckfin.uclinux.org>
 
This is a followup to the cleanups for earlyprintk patch from Gerd Hoffmann
 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=69331af79cf29e26d1231152a172a1a10c2df511
 
This ensures that a bootconsole is unregistered if it is not replaced.
The current implementation spews garbage out the bootconsole in this case,
since the bootconsole structure is normally in the init section, and is
freed, but still used.
 
Signed-off-by: Robin Getz <rgetz@...ckfin.uclinux.org>
CC: Gerd Hoffmann <kraxel@...hat.com>
CC: Paul Mundt <lethal@...ux-sh.org>
CC: Mike Frysinger <vapier.adi@...il.com>
---

 kernel/printk.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

Index: linux-2.6.x/kernel/printk.c
===================================================================
--- linux-2.6.x/kernel/printk.c	(revision 3583)
+++ linux-2.6.x/kernel/printk.c	(working copy)
@@ -1104,6 +1104,17 @@
 }
 EXPORT_SYMBOL(unregister_console);
 
+static int __init disable_boot_consoles(void)
+{
+	if (console_drivers->flags & CON_BOOT) {
+		printk(KERN_INFO "turn off boot console %s%d\n",
+			console_drivers->name, console_drivers->index);
+		return unregister_console(console_drivers);
+	}
+	return 0;
+}
+late_initcall(disable_boot_consoles);
+
 /**
  * tty_write_message - write a message to a certain tty, not just the console.
  * @tty: the destination tty_struct
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/