linux-kernel - Re: [PATCH] rtc: Make rtc-rs5c348 driver hotplug-aware (take 2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200708191849.16648.david-b@pacbell.net>
Date:	Sun, 19 Aug 2007 18:49:16 -0700
From:	David Brownell <david-b@...bell.net>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
Cc:	a.zummo@...ertech.it, linux-kernel@...r.kernel.org,
	rtc-linux@...glegroups.com, ralf@...ux-mips.org
Subject: Re: [PATCH] rtc: Make rtc-rs5c348 driver hotplug-aware (take 2)

On Sunday 19 August 2007, Atsushi Nemoto wrote:
> The rtc-rs5c348 SPI driver name doesn't match its module name, which
> prevents it from properly hotplugging.  There is only one in-tree user
> of its driver, which is fixed by this patch too.
> 
> Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>

ACK.

> ---
>  arch/mips/tx4938/toshiba_rbtx4938/setup.c |    2 +-
>  drivers/rtc/rtc-rs5c348.c                 |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/tx4938/toshiba_rbtx4938/setup.c b/arch/mips/tx4938/toshiba_rbtx4938/setup.c
> index 57f3c70..84ebff7 100644
> --- a/arch/mips/tx4938/toshiba_rbtx4938/setup.c
> +++ b/arch/mips/tx4938/toshiba_rbtx4938/setup.c
> @@ -1115,7 +1115,7 @@ static void __init txx9_spi_init(unsigned long base, int irq)
>  static int __init rbtx4938_spi_init(void)
>  {
>  	struct spi_board_info srtc_info = {
> -		.modalias = "rs5c348",
> +		.modalias = "rtc-rs5c348",
>  		.max_speed_hz = 1000000, /* 1.0Mbps @ Vdd 2.0V */
>  		.bus_num = 0,
>  		.chip_select = 16 + SRTC_CS,
> diff --git a/drivers/rtc/rtc-rs5c348.c b/drivers/rtc/rtc-rs5c348.c
> index f50f3fc..8394626 100644
> --- a/drivers/rtc/rtc-rs5c348.c
> +++ b/drivers/rtc/rtc-rs5c348.c
> @@ -226,7 +226,7 @@ static int __devexit rs5c348_remove(struct spi_device *spi)
>  
>  static struct spi_driver rs5c348_driver = {
>  	.driver = {
> -		.name	= "rs5c348",
> +		.name	= "rtc-rs5c348",
>  		.bus	= &spi_bus_type,
>  		.owner	= THIS_MODULE,
>  	},
> 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/