linux-kernel - Re: [PATCH 1/1] ensure we don't use bootconsoles after init has been released

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Aug 2007 12:31:43 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	Robin Getz <rgetz@...ckfin.uclinux.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Gerd Hoffmann <kraxel@...hat.com>
Subject: Re: [PATCH 1/1] ensure we don't use bootconsoles after init has been released

On Sun, Aug 19, 2007 at 11:11:47PM -0400, Mike Frysinger wrote:
> On 8/19/07, Robin Getz <rgetz@...ckfin.uclinux.org> wrote:
> > +static int __init disable_boot_consoles(void)
> > +{
> > +       struct console *con;
> > +
> > +       for (con = console_drivers; con; con = con->next) {
> > +               if (con->flags & CON_BOOT) {
> > +                       printk(KERN_INFO "Turn off boot console %s%d\n",
> > +                               con->name, con->index);
> > +                       unregister_console(con);
> > +               }
> > +       }
> > +}
> 
> erp, no 'return 0;' ... that'll earn you a warning at build time and
> maybe random failures depending on the arch ...

Or better yet, complain if unregister_console() fails, and pass the
failure down.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/