linux-kernel - Re: [PATCH 6/6] Do not use FASTCALL for __alloc_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070821102535.GF29794@skynet.ie>
Date:	Tue, 21 Aug 2007 11:25:35 +0100
From:	mel@...net.ie (Mel Gorman)
To:	Andi Kleen <ak@...e.de>
Cc:	Christoph Lameter <clameter@....com>, Lee.Schermerhorn@...com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 6/6] Do not use FASTCALL for __alloc_pages_nodemask()

On (18/08/07 14:51), Andi Kleen didst pronounce:
> On Friday 17 August 2007 23:07:33 Christoph Lameter wrote:
> > On Fri, 17 Aug 2007, Mel Gorman wrote:
> > 
> > > Opinions as to why FASTCALL breaks on one machine are welcome.
> > 
> > Could we get rid of FASTCALL? AFAIK the compiler should automatically 
> > choose the right calling convention?
> 
> It was a nop for some time because register parameters are always enabled
> on i386 and AFAIK no other architectures ever used it. Some out of tree
> trees some to disable register parameters though, but that's not 
> really a concern.
> 

You're right. It now makes even less sense why it was a PPC64 machine that
exhibited the problem. It should have made no difference at all.

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/