[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070821104121.GA26598@elte.hu>
Date: Tue, 21 Aug 2007 12:41:21 +0200
From: Ingo Molnar <mingo@...e.hu>
To: "Eric W. Biederman" <ebiederm@...ssion.com>
Cc: Michal Piotrowski <michal.k.k.piotrowski@...il.com>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org,
Nick Piggin <nickpiggin@...oo.com.au>,
Alexey Dobriyan <adobriyan@...ru>
Subject: Re: 2.6.23-rc2-mm2
* Eric W. Biederman <ebiederm@...ssion.com> wrote:
> Ok. I missed that. Duh. I just saw Andrews drop message.
>
> This looks like Alexey respun my patch, or else we were thinking on
> parallel paths. Probably parallel given Alexey's dislike of using the
> CTL_UNNUMBERED define.
>
> There are two remaining gotchas:
> - The directories have impossible permissions (writeable).
>
> - The ctl_name for the kernel directory is inconsistent with
> everything else. It should be CTL_KERN.
thx, i've applied your patch to my tree.
> I kind of feel bad about being so picky but the this code is the only
> place in the kernel where I have seen us violate either of those
> rules, and it is a lot easier to deal with things when they are
> consistent.
sure enough, i'm not opposed at all to fixing these issues. We should
move your debug-sysctl-bugs patch upstream ASAP.
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists