linux-kernel - Re: [PATCH] AH4: Update IPv4 options handling to conform to RFC 4302.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070822081210.GA608@gondor.apana.org.au>
Date:	Wed, 22 Aug 2007 16:12:10 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Nick Bowler <nbowler@...ipticsemi.com>
Cc:	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>
Subject: Re: [PATCH] AH4: Update IPv4 options handling to conform to RFC 4302.

On Tue, Aug 21, 2007 at 02:44:33PM +0000, Nick Bowler wrote:
> In testing our ESP/AH offload hardware, I discovered an issue with how AH
> handles mutable fields in IPv4.  RFC 4302 (AH) states the following on the
> subject:
> 
>         For IPv4, the entire option is viewed as a unit; so even
>         though the type and length fields within most options are immutable
>         in transit, if an option is classified as mutable, the entire option
>         is zeroed for ICV computation purposes.

Good catch! Very few people test IP options so this one slipped
through.  Fortunately by the same token we can change this
without anybody noticing.

This requirement isn't new with 4302, 2402 says exactly the
same thing.

Please resend your patch to davem@...emloft.net with a cc to
netdev@...r.kernel.org.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/