[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0708221049230.13436@schroedinger.engr.sgi.com>
Date: Wed, 22 Aug 2007 10:50:47 -0700 (PDT)
From: Christoph Lameter <clameter@....com>
To: Shaohua Li <shaohua.li@...el.com>
cc: lkml <linux-kernel@...r.kernel.org>, kamezawa.hiroyu@...fujitsu.com
Subject: Re: bug in migrate page
On Wed, 22 Aug 2007, Shaohua Li wrote:
> commit dc386d4d1e98bb39fb967ee156cd456c802fc692 adds rcu_read_lock, but
> some routines in the lock range might sleep (like lock_buffer,
> aops->writepage), I saw a 'sleep in atomic' warning. It appears the
> patch has several versions before. Doing rcu_read_lock in PageAnon
> sounds break the case of PageAnon(page) && PageSwapCache(page),
> as .writepage might be called. The dummy anon patch maybe is ok.
Ok so we agree that .writepage is not used. Anonymous pages also do not
not have buffers. Only taking the rcu lock on page_anon() would suffice
to fix this right?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists