linux-kernel - Re: 2.6.23-rc3-mm1: net/wireless/rt2x00mac.c build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200708222222.13618.rjw@sisk.pl>
Date:	Wed, 22 Aug 2007 22:22:12 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Ivo van Doorn <ivdoorn@...il.com>
Cc:	Mariusz Kozlowski <m.kozlowski@...land.pl>,
	John Linville <linville@...driver.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: 2.6.23-rc3-mm1: net/wireless/rt2x00mac.c build failure

On Wednesday, 22 August 2007 22:12, Ivo van Doorn wrote:
> Hi,
> 
> >   CC [M]  drivers/net/wireless/zd1211rw-mac80211/zd_mac.o
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c: In function `zd_op_erp_ie_changed':
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:822: error: `IEEE80211_ERP_CHANGE_PREAMBLE' undeclared (first use in this function)
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:822: error: (Each undeclared identifier is reported only once
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:822: error: for each function it appears in.)
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c: At top level:
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:844: error: unknown field `erp_ie_changed' specified in initializer
> > drivers/net/wireless/zd1211rw-mac80211/zd_mac.c:844: warning: initialization from incompatible pointer type
> > make[4]: *** [drivers/net/wireless/zd1211rw-mac80211/zd_mac.o] Error 1
> > make[3]: *** [drivers/net/wireless/zd1211rw-mac80211] Error 2
> > make[2]: *** [drivers/net/wireless] Error 2
> > make[1]: *** [drivers/net] Error 2
> > make: *** [drivers] Error 2
> 
> I'm not a zd1211rw developer, but a quick look into the patch series it seems
> that the mac80211 version in -mm1 does not contain the patch
> [PATCH 4/4] mac80211: implement ERP info change notifications
> But it does contain the zd1211rw patch:
> [PATCH] zd1211rw-mac80211: use correct preambles for RTS/CTS frames
> Which depended on the above mentioned mac80211 patch.
> 
> Just had a second thought about those rt2x00 compilation errors you reported,
> the error is not caused by rt2x00 lagging behind mac80211 api changes but
> that rt2x00 patches to follow the api changes are going upstream but
> the mac80211 api changes it depends on are not going anywhere.
> 
> It seems that mac80211 has not been updated in the -mm tree while the
> drivers have been updated. This is causing the compilation errors for both
> rt2x00 as zd1211rw.
> I'll bet that if you try any other mac80211 driver similar issues will arise.

Yup.  This also happens to the b43 driver, for example.

Greetings,
Rafael


-- 
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/