linux-kernel - Re: [PATCH][2.6.23-rc2-mm2] small fix for ia64 icache sync patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070822091129.8c300281.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Wed, 22 Aug 2007 09:11:29 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	"LKML" <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	<linux-ia64@...r.kernel.org>
Subject: Re: [PATCH][2.6.23-rc2-mm2] small fix for ia64 icache sync patch

On Tue, 21 Aug 2007 14:12:02 -0700
"Luck, Tony" <tony.luck@...el.com> wrote:

> > +	if (pte_present(pteval) &&// swap out ?
> > +	    pte_exec(pteval) &&    // flush only new executable page.
> > 	    pte_user(pteval) &&    // ignore kernel page
> > 	    (!pte_present(*ptep) ||// do_no_page or swap in, migration,
> > 		pte_pfn(*ptep) != pte_pfn(pteval))) // do_wp_page(), page copy
> 
> David Mosberger was concerned about the increase in code
> size from this inline function.  We can reduce the bloat
> a bit by defining a macro that tests for "present &&
> executable && user-mode" in one go:
> 
> #define pte_pux(pte)            ((pte_val(pte) & (_PAGE_P|_PAGE_PL_MASK|_PAGE_AR_RX)) == \
>                                         (_PAGE_P|_PAGE_PL_3|_PAGE_AR_RX))
> 
Hmm, ok.

> Perhaps there is a better name than "pte_pux"?  I don't know whether
> the code that this generates is faster, but it is smaller (bloat
> is only 3k instead of 4k).
> 
> One last cleanup needed ... don't use C-99/C++ style comments.
> 
ok.

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/