linux-kernel - Re: [patch 09/14] Convert from class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1187907172.3632.43.camel@lov.localdomain>
Date:	Fri, 24 Aug 2007 00:12:52 +0200
From:	Kay Sievers <kay.sievers@...y.org>
To:	David Brownell <david-b@...bell.net>
Cc:	Tony Jones <tonyj@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [patch 09/14] Convert from class_device to device for SPI

On Thu, 2007-08-23 at 14:03 -0700, David Brownell wrote:
> On Tuesday 21 August 2007, Tony Jones wrote:
> > I believe this is the necessary documentation changes.
> 
> Thanks.  I have an update, plus updates for the mmc_spi
> driver (now in MM) which you didn't update.
> 
> By the way, it's worth noting an incompatibility introduced
> through these conversions and CONFIG_SYSFS_DEPRECATED=n:
> 
>  - previously .../controller/spi_master:spi2 would be a
>    symlink to /sys/class/spi_master/spi2

These "find the class device which has me as the parent"-symlinks are
removed with CONFIG_SYSFS_DEPRECATED=n, because these devices are direct
child directories now below the bus device and there is no need for such
links.

>  - now, /sys/class/spi_master/spi2 is a symlink to
>    .../controller/spi_master (with DEPRECATED=n).

Ugh! Are you sure, that is doesn't point to:
  .../controller/spi_master/spi2/ ?

> The symlink direction is just noise ... the issue is that with
> this approach it's no longer possible to have one controller
> handle multiple SPI busses!  A fix would involve maintaining
> the original "spi_master:spi2" name.

Sounds like a bug if that's what happened. Can you paste the output of
"tree" for the relevant parts here?

Thanks,
Kay


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/